Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update target path naming hierarchy TDE-955 #845

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

MDavidson17
Copy link
Contributor

@MDavidson17 MDavidson17 commented Jan 31, 2024

Motivation

The target path name formatting is inconsistent with the final decisions in the naming.md
It is now expected that the event name will be included in the geographic_description field as well.

Sometimes the event name includes the location (Top of the South Floods) and sometimes it does not (Cyclone Gabrielle) Therefore it is difficult to determine whether to merge the event_name with the region/geographic_description.

It is also preferable to keep the event_name consistent across all imagery so that datasets can be filtered by events for example the Cyclone Gabrielle imagery in Hawkes Bay, Gisborne & the North Island should all have event_name=Cyclone Gabrielle.

examples:

inputs: region=Hawke's Bay gd= Hawke's Bay Cyclone Gabrielle event_name=Cyclone Gabrielle
paths: s3://nz-imagery/hawkes-bay/hawkes-bay-cyclone-gabrielle_2023_0.1m/

inputs: region=Nelson gd= Top of the South Floods event_name=Top of the South Floods
paths: s3://nz-imagery/nelson/top-of-the-south-floods_2023_0.1m/

inputs: region=Auckland
paths: s3://nz-imagery/auckland/auckland_2023_0.1m/

inputs: region=Wellington gd=Upper Hutt
paths: s3://nz-imagery/wellington/upper-hutt_2023_0.1m/

Modification

name portion of the target path changed from:

if geographic_descr return geographic_descr-event?
else return region-event?

to

if geographic_descr return geographic_descr
return region

Checklist

If not applicable, provide explanation of why.

  • Tests updated
    - [ ] Docs updated - n/a
  • Issue linked in Title

@MDavidson17 MDavidson17 marked this pull request as ready for review February 2, 2024 00:50
@MDavidson17 MDavidson17 requested review from a team as code owners February 2, 2024 00:50
@MDavidson17 MDavidson17 requested a review from dwsilk February 2, 2024 02:53
@MDavidson17 MDavidson17 added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 5a8678d Feb 8, 2024
2 checks passed
@MDavidson17 MDavidson17 deleted the fix/naming-hierarchy branch February 8, 2024 00:32
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2024
🤖 I have created a release *beep* *boop*
---


## [3.0.0](v2.18.2...v3.0.0)
(2024-02-11)


### ⚠ BREAKING CHANGES

* automate target path TDE-961
([#828](#828))

### Features

* automate target path TDE-961
([#828](#828))
([7dd206a](7dd206a))
* Handle 1:50k imagery TDE-1014
([#855](#855))
([8be7266](8be7266))
* Slugify strings TDE-1019
([#827](#827))
([b0a7874](b0a7874))


### Bug Fixes

* add tiff url to error messages TDE-961
([#844](#844))
([3f4b174](3f4b174))
* interim fix for Rakiura Stewart Island tiles TDE-1015
([#857](#857))
([3b6e23f](3b6e23f))
* update target path naming hierarchy TDE-955
([#845](#845))
([5a8678d](5a8678d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants